-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
venv_backend
new options and choices
#316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarie
changed the title
New global option
Apr 22, 2020
nox.options.venv_backend
to set the default backendvenv_backend
new options and choices
…s well as the new 'none' backend
…cted. It is now only logged when session is run.
…ed corresponding tests. This should make coverage happy, too.
Finally all set and ready for review :) @theacodes @sethmlarson |
…(or python=False). Previously a `ValueError` was raised. Fixes wntrblm#318
theacodes
approved these changes
May 24, 2020
Thanks @theacodes for the review, and thanks for merging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog (let me know if I should commit it in the changelog file):
nox.options.default_venv_backend
to set the default backend. Fixes New global optionnox.options.venv_backend
to set the default backend #315nox.options.force_venv_backend
to temporarily force the backend. The commandline version of this option will probably be used more frequently than the noxfile one, but thanks to the great generic option mechanism built in nox, I got both for the same price :) . Fixes Be able to force the backend temporarily #317venv_backend='none'
(or to force it temporarily with the--no-venv
cli option, equivalent to--force-venv-backend none
, see above). Fixes Add a command line option for setting python=False #301install
andconda_install
work when there is no venv backend (or python=False). Previously aValueError
was raised. Fixes Allowsession.install
andsession.conda_install
to run when no venv backend is set #318I updated the doc accordingly.